Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext/bcmath - Added bcceil, bcfloor, bcround and bcdivmod #4132

Merged
merged 12 commits into from
Nov 25, 2024
Merged

ext/bcmath - Added bcceil, bcfloor, bcround and bcdivmod #4132

merged 12 commits into from
Nov 25, 2024

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented Nov 23, 2024 •
edited
Loading

RFC:
https://wiki.php.net/rfc/adding_bcround_bcfloor_bcceil_to_bcmath
https://wiki.php.net/rfc/add_bcdivmod_to_bcmath

I found an error in the existing documentation regarding bcdiv and bcmod.
But instead of this PR, I'll follow it up with another PR.

Regarding errors/exceptions, I will add everything except bcdivmod later.

@SakiTakamachi SakiTakamachi force-pushed the bcmath/new_functions branch 2 times, most recently from ccfc782 to a08ba3e Compare November 23, 2024 04:47
@SakiTakamachi SakiTakamachi changed the title Added bcceil, bcfloor, bcround and bcdivmod ext/bcmath - Added bcceil, bcfloor, bcround and bcdivmod Nov 23, 2024
@SakiTakamachi SakiTakamachi changed the title ext/bcmath - Added bcceil, bcfloor, bcround and bcdivmod ext/bcmath - Added bcceil, bcfloor, bcround and bcdivmod Nov 23, 2024
@nielsdos
Copy link
Member

nielsdos commented Nov 23, 2024 •
edited
Loading

I will wait for reviewing this when the other 2 PRs are updated based on my review comments, as some similar markup mistakes are in this PR.

@SakiTakamachi
Copy link
Member Author

done

@SakiTakamachi
Copy link
Member Author

Oh, no, there's more

@SakiTakamachi
Copy link
Member Author

done!

Girgias
Girgias requested changes Nov 24, 2024
View reviewed changes
SakiTakamachi and others added 3 commits November 24, 2024 14:53
@SakiTakamachi @Girgias
address a comment
459f55e 
Co-authored-by: Gina Peter Banyard <[email protected]>
@SakiTakamachi @Girgias
address a comment
310a17c 
Co-authored-by: Gina Peter Banyard <[email protected]>
@SakiTakamachi
Address comments
6044026
@SakiTakamachi
Copy link
Member Author

fixed!

nielsdos
nielsdos requested changes Nov 24, 2024
View reviewed changes
reference/bc/functions/bcceil.xml Outdated
<refentry xml:id="function.bcceil" xmlns="http://docbook.org/ns/docbook">
<refnamediv>
<refname>bcceil</refname>
<refpurpose>Round arbitrary precision number fractions up</refpurpose>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the description very weird sounding, this doesn't really read like a proper sentence. Similar for the other functions.

Copy link
Member Author

@SakiTakamachi SakiTakamachi Nov 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit) How about 'Round up the fractional part of an arbitrary precision number' ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just "Round up arbitrary precision number" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed in 3d93dce

SakiTakamachi and others added 4 commits November 24, 2024 22:29
@SakiTakamachi @nielsdos
address a comment
1a647cc 
Co-authored-by: Niels Dossche <[email protected]>
@SakiTakamachi @nielsdos
address a comment
11c77a9 
Co-authored-by: Niels Dossche <[email protected]>
@SakiTakamachi @nielsdos
address a comment
77df1ae 
Co-authored-by: Niels Dossche <[email protected]>
@SakiTakamachi
Address comments
3d93dce
nielsdos
nielsdos approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this is fine now

Girgias
Girgias reviewed Nov 24, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment about showing the output of examples, but otherwise LGTM

reference/bc/functions/bcfloor.xml Outdated
Comment on lines 46 to 54
<programlisting role="php">
<![CDATA[
<?php
echo bcfloor('4.3'); // '4'
echo bcfloor('9.999'); // '9'
echo bcfloor('-3.14'); // '-4'
?>
]]>
</programlisting>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to use var_dump() and show the result of the example via a <screen> tag rather than a comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed it in 501f4d9

@Girgias Girgias merged commit 87f3287 into php:master Nov 25, 2024
2 checks passed
@SakiTakamachi SakiTakamachi deleted the bcmath/new_functions branch November 25, 2024 22:15
@SakiTakamachi
Copy link
Member Author

Thanks!

@Girgias Girgias mentioned this pull request Dec 1, 2024
Open
@KentarouTakeda KentarouTakeda mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SakiTakamachi @nielsdos @Girgias