Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document 8.4 changes in openssl_csr_new #4315

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Document 8.4 changes in openssl_csr_new #4315

merged 1 commit into from
Dec 21, 2024

Conversation

bukka
Copy link
Member

@bukka bukka commented Dec 15, 2024

This clarifies distinguished_names and extra_attributes params as well.

@bukka bukka mentioned this pull request Dec 15, 2024
Open
Girgias
Girgias approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, LGTM otherwise.

@siwa32 siwa32 mentioned this pull request Dec 21, 2024
Open
@bukka bukka force-pushed the openssl_csr_new_84 branch from b4e5329 to f77954e Compare December 21, 2024 10:23
@bukka bukka merged commit f0d1192 into php:master Dec 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bukka @Girgias