Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade PHPUnit #421

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Upgrade PHPUnit #421

merged 2 commits into from
Nov 17, 2017

Conversation

keradus
Copy link
Contributor

@keradus keradus commented Nov 11, 2017 •
edited
Loading

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets n/a

Brought to you by PHP CS Fixer

@Landerstraeten Landerstraeten added this to the Version 0.12.1 milestone Nov 17, 2017
@keradus
Copy link
Contributor Author

keradus commented Nov 17, 2017

thanks for contribution ;)

@veewee
Copy link
Contributor

veewee commented Nov 17, 2017

No problem. It seems to fail on PHP 5.6 (with prefer lowest). Can you take a look at it?
https://travis-ci.org/phpro/grumphp/jobs/303537284

@keradus
Copy link
Contributor Author

keradus commented Nov 17, 2017

ha, on my commit it was passing :D

@keradus
Copy link
Contributor Author

keradus commented Nov 17, 2017

fixed.

@Landerstraeten Landerstraeten merged commit cbd2c89 into phpro:master Nov 17, 2017
@Landerstraeten
Copy link
Contributor

Thank you @keradus!

@keradus keradus deleted the phpunit branch November 18, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Landerstraeten Landerstraeten Landerstraeten approved these changes

@veewee veewee Awaiting requested review from veewee

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Version 0.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@keradus @veewee @Landerstraeten