Add parse_constant and parse_custom_tags options to yamllint task #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfont 3.2 and 3.3, the Yaml component added support for PHP constants and custom tags.
Currently when using constants or custom tags in a Yaml file, the yamllint task fails because the syntax is invalid (and the necessary flags is not passed through).
This PR adds 2 new options to the yamllint task:
parse_constant&parse_custom_tags. These options default to false to keep current behaviour. If they are set totrue, then the required flags is passed through to the Yaml::parse method so that the task doesn't fail.