Remove proxy manager #435
Remove proxy manager #435
Conversation
Landerstraeten
force-pushed
the
remove-proxy-manager
branch
from
86f4e5a to
aaed186
Compare
src/Console/Application.php
Outdated
| @@ -51,6 +52,8 @@ public function __construct() | |||
| $this->filesystem = new Filesystem(); | |||
| $this->container = $this->getContainer(); | |||
| $this->setDispatcher($this->container->get('event_dispatcher')); | |||
| $this->container->set('console.input', new ArgvInput()); | |||
There was a problem hiding this comment.
This won't work since the output / input wont be configured meaning the verbosity level is not available on the output in the service grumphp.io.console (which is still marked as lazy). The grumphp.io is required before the configureIO() method was called.
You can validate this by running the code with the verbose flag -v: You won't see the additional information.
Landerstraeten
force-pushed
the
remove-proxy-manager
branch
2 times, most recently
from
7a469bb to
a1f992e
Compare
|
Hi @Landerstraeten, |
Landerstraeten
force-pushed
the
remove-proxy-manager
branch
from
a1f992e to
2637454
Compare
|
Hi @Landerstraeten, |
|
@EugeneZub, |
|
Hi @veewee, |
Landerstraeten
force-pushed
the
remove-proxy-manager
branch
from
2637454 to
d72bf2f
Compare
src/Console/Application.php
Outdated
| // Register the console input and output to the container | ||
| $container->set('console.input', $input); | ||
| $container->set('console.output', $output); | ||
| parent::configureIO($input, $output); |
There was a problem hiding this comment.
This won't work since you now configure the input and output from the container and not the ones that are available in the commands. This means the arguments and options won't work in the commands. As you can see, the configureIO() does not return anything and should just configure the arguments that are being passed to the method.
src/Console/Application.php
Outdated
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function setDispatcher(EventDispatcherInterface $dispatcher) |
There was a problem hiding this comment.
Why did you move this one outside the constructor? It seems better to set a dispatcher then to overwrite thet set* method.
| /** | ||
| * @return InputInterface | ||
| */ | ||
| public function getInput() |
There was a problem hiding this comment.
Why did you add these getters? They are not being used at the moment, so I would not make them available at this point.
Landerstraeten
force-pushed
the
remove-proxy-manager
branch
2 times, most recently
from
67a5f33 to
da216d1
Compare
Landerstraeten
force-pushed
the
remove-proxy-manager
branch
from
da216d1 to
b5a4aab
Compare
As the title says, remove the proxy manager.
@veewee (and everyone else), please leave your remaks below.