Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GrumPHP ProcessUtils over Symfonys, fixes Formatter not working w… #443

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Use GrumPHP ProcessUtils over Symfonys, fixes Formatter not working w… #443

merged 2 commits into from
Jan 17, 2018

Conversation

vrielsa
Copy link
Contributor

@vrielsa vrielsa commented Jan 16, 2018

Q A
Branch master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets n/a

Fixes incompatibility with Symfony 4.x Process component when using php-cs-fixer

@keradus
Copy link
Contributor

keradus commented Jan 16, 2018

Hi ;)
Looks nice ;)
Yet, please also update

  • spec/Formatter/PhpCsFixerFormatterSpec.php
  • spec/Process/ProcessBuilderSpec.php

keradus
keradus approved these changes Jan 16, 2018
View reviewed changes
Copy link
Contributor

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really nice 👍 ❤️ !

@veewee veewee added this to the Version 0.13.1 milestone Jan 17, 2018
@veewee veewee merged commit e0a7220 into phpro:master Jan 17, 2018
@veewee
Copy link
Contributor

veewee commented Jan 17, 2018

Thanks @vrielsa !

@veewee veewee mentioned this pull request Jan 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Version 0.13.1
Development

Successfully merging this pull request may close these issues.
3 participants
@vrielsa @keradus @veewee