Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_parse_errors option to ComposerRequireChecker #460

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Add ignore_parse_errors option to ComposerRequireChecker #460

merged 1 commit into from
Feb 23, 2018

Conversation

jyggen
Copy link
Contributor

@jyggen jyggen commented Feb 5, 2018

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets -

This adds an option to enable --ignore-parse-errors, which is available in ComposerRequireChecker since 0.2.0.

One thing to note is that the world will crash and burn ComposerRequireChecker will throw a hissy fit if you have <0.2.0 installed and enable this. I think pointing this out in the docs should be good enough since the option is opt-in. We could always go down the route of version detection, but composer-require-checker --version identifies itself as 0.1.1-dev on 0.2.0 :(

@veewee veewee added this to the Version 0.14.0 milestone Feb 7, 2018
@veewee
Copy link
Contributor

veewee commented Feb 7, 2018

Looks good to me. The documentation is clear to me. I would also avoid the version detection.

@veewee veewee merged commit 9553adc into phpro:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants