Force git hooks to contain unix styled commands #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2018
| $arguments = $this->createArgumentsForCommand('grumphp'); | ||
| $arguments = $this->createArgumentsForCommand('grumphp', false); | ||
| $arguments->shouldHaveType(ProcessArgumentsCollection::class); | ||
| $arguments[0]->shouldBe('/usr/bin/grumphp'); |
There was a problem hiding this comment.
$arguments->shouldHaveKeyWithValue(0, '/usr/bin/grumphp');
There was a problem hiding this comment.
To me, it's more readable as it is right now
src/Process/ProcessBuilder.php
Outdated
| @@ -43,11 +43,12 @@ public function __construct(GrumPHP $config, ExternalCommand $externalCommandLoc | |||
| /** | |||
| * @param string $command | |||
| * | |||
| * @param bool $forceUnix | |||
There was a problem hiding this comment.
I think this should be on line 45 (swap the newline)
Landerstraeten
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced in version 0.13 : before we used to force the git hook command to be unix styled.
(reference: 415fd1a#diff-aed6b638f2d7de8614c3516d7939c1a0L135 )