Add ignore patterns for File size task #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Landerstraeten
commented
Mar 30, 2018
Landerstraeten
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Documented? | yes |
veewee
reviewed
Mar 30, 2018
src/Task/FileSize.php
Outdated
| $files = $context->getFiles()->size(sprintf('>%s', $maxSize)); | ||
| $files = $context->getFiles() | ||
| ->size(sprintf('>%s', $maxSize)) | ||
| ->notPaths($config['ignore_patterns']); |
There was a problem hiding this comment.
Beter to run notPaths() before size.
Landerstraeten
force-pushed
the
ignore-patters-filesize-task
branch
2 times, most recently
from
299dfc0 to
6822aee
Compare
veewee
approved these changes
Apr 3, 2018
|
Can you rebase? |
Landerstraeten
force-pushed
the
ignore-patters-filesize-task
branch
from
6822aee to
fbdd6a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.