Add psalm #510
Merged
Add psalm #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
reviewed
Jun 29, 2018
src/Task/Psalm.php
Outdated
| 'ignore_patterns' => [], | ||
| 'no_cache' => false, | ||
| 'report' => null, | ||
| 'threads' => 1, |
There was a problem hiding this comment.
Maybe it is better to set this to null and let psalm decide what it uses by default?
| ignore_patterns: [] | ||
| no_cache: false | ||
| report: ~ | ||
| threads: 1 |
There was a problem hiding this comment.
The threads options is not described in the documentation
src/Task/Psalm.php
Outdated
| $arguments->addOptionalArgument('--report=%s', $config['report']); | ||
| $arguments->addOptionalArgument('--no-cache', $config['no_cache']); | ||
| $arguments->addOptionalArgument('--threads=%d', $config['threads']); | ||
| $arguments->addFiles($files); |
There was a problem hiding this comment.
During run, the file list might get very big. Would it make sense to only add the files during pre-commit context and run on all files during run context?
There was a problem hiding this comment.
That does make sense, will fix!
added 5 commits
July 5, 2018 13:59
|
Thanks for adding the docs, we'll merge it in with the next milestone release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds a task for Psalm
New Task Checklist:
run()method readable?run()method using the configuration correctly?