Small performance optimization #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Task/Git/CommitMessage.php
Outdated
| @@ -156,7 +156,7 @@ private function enforceTextWidth(ContextInterface $context): TaskResult | |||
| } | |||
| } | |||
|
|
|||
| if (count($errors) > 0) { | |||
| if (\count($errors) > 0) { | |||
There was a problem hiding this comment.
Can you change this to if (\count($errors) {}
src/Task/PhpMd.php
Outdated
| @@ -58,12 +58,12 @@ public function run(ContextInterface $context): TaskResultInterface | |||
| $extensions = $config['triggered_by']; | |||
|
|
|||
| $files = $context->getFiles(); | |||
| if (0 !== count($whitelistPatterns)) { | |||
| if (0 !== \count($whitelistPatterns)) { | |||
There was a problem hiding this comment.
Can you change this to if (\count($whitelistPatterns)) {}
src/Task/YamlLint.php
Outdated
| @@ -54,10 +54,10 @@ public function run(ContextInterface $context): TaskResultInterface | |||
|
|
|||
| /** @var FilesCollection $files */ | |||
| $files = $context->getFiles()->name($extensions); | |||
| if (count($whitelistPatterns) >= 1) { | |||
| if (\count($whitelistPatterns) >= 1) { | |||
There was a problem hiding this comment.
Can you change this to if (\count($whitelistPatterns)) {}
src/Task/Phpcs.php
Outdated
| @@ -70,12 +70,12 @@ public function run(ContextInterface $context): TaskResultInterface | |||
|
|
|||
| /** @var \GrumPHP\Collection\FilesCollection $files */ | |||
| $files = $context->getFiles(); | |||
| if (0 !== count($whitelistPatterns)) { | |||
| if (0 !== \count($whitelistPatterns)) { | |||
There was a problem hiding this comment.
Can you change this to if (\count($whitelistPatterns)) {}
laurieplo
force-pushed
the
small-performance-optimization
branch
from
fc9bf08 to
359738a
Compare
veewee
reviewed
Oct 26, 2018
src/Util/Regex.php
Outdated
| @@ -33,7 +33,7 @@ public function __construct(string $string) | |||
| private function isRegex(string $string): bool | |||
| { | |||
| if (preg_match('/^(.{3,}?)['.self::ALLOWED_MODIFIERS.']*$/', $string, $m)) { | |||
| $start = substr($m[1], 0, 1); | |||
| $start = $m[1][0]; | |||
There was a problem hiding this comment.
I would prefer to use a string function here to avoid confusion.
veewee
reviewed
Oct 26, 2018
| @@ -45,7 +45,7 @@ private function formatOutput(string $output): string | |||
| { | |||
| $result = static::RESET_COLOR; | |||
| foreach (array_filter(explode("\n", $output)) as $lineNumber => $line) { | |||
| $result .= preg_match('/^[0-9]+/', $line) ? $this->trimOutputLine($line, (int) $lineNumber) : $line; | |||
| $result .= preg_match('/^\d+/', $line) ? $this->trimOutputLine($line, (int) $lineNumber) : $line; | |||
There was a problem hiding this comment.
I would prefer [0-9] here since it is easier to folow then the \d alternative.
laurieplo
force-pushed
the
small-performance-optimization
branch
2 times, most recently
from
1952e7e to
76c5b93
Compare
|
Hi @laurieplo, Thanks for your effort. Can you fix the failing tests/build? |
laurieplo
force-pushed
the
small-performance-optimization
branch
from
76c5b93 to
170fb07
Compare
Yes, sorry @Landerstraeten ! It is fixed. |
Landerstraeten
approved these changes
Oct 31, 2018
Landerstraeten
force-pushed
the
small-performance-optimization
branch
from
170fb07 to
f43f215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of very small changes that will affect performance and maintanability (fully-qualified function calls, ===/!==, return optimization, ...)