Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create succeeded.txt #597

Merged
merged 3 commits into from
Mar 7, 2019
Merged

Create succeeded.txt #597

merged 3 commits into from
Mar 7, 2019

Conversation

guifelix
Copy link
Contributor

Create a simpler succeeded message

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets no

add another text template to succeeded message

@guifelix
Create succeeded.txt
b6912b1 
Create a simpler succeeded message
@Landerstraeten Landerstraeten self-requested a review February 28, 2019 17:33
@veewee
Copy link
Contributor

veewee commented Mar 1, 2019

Hello @guifelix ,

Can you also update the documentation?
https://github.com/phpro/grumphp/blob/master/doc/parameters.md
-> ascii

Thanks!

@guifelix
Copy link
Contributor Author

guifelix commented Mar 2, 2019

@veewee how do I commit a new file in this same PR? I've never done that

@jyggen
Copy link
Contributor

jyggen commented Mar 2, 2019

@veewee how do I commit a new file in this same PR? I've never done that

Commit the changes you want to make to the branch patch-2 on your fork.

@veewee veewee added this to the 0.15.1 milestone Mar 7, 2019
@veewee veewee merged commit ae8d2ad into phpro:master Mar 7, 2019
@veewee
Copy link
Contributor

veewee commented Mar 7, 2019

Thanks for the PRs!

@guifelix guifelix deleted the patch-2 branch April 20, 2021 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Landerstraeten Landerstraeten Landerstraeten approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.15.1
Development

Successfully merging this pull request may close these issues.
4 participants
@guifelix @veewee @jyggen @Landerstraeten