Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show project files when project is in subfolder #643

Merged
merged 1 commit into from
May 31, 2019

Conversation

veewee
Copy link
Contributor

@veewee veewee commented May 31, 2019

Q A
Branch master
Bug fix? yes
New feature? yes
BC breaks? yes
Deprecations? no
Documented?
Fixed tickets #607, #592

This PR will fix invalid files when using grumphp.yml + composer.jshon in a single subdirectory inside git.

For example: ./project

@veewee veewee added this to the 0.16.0 milestone May 31, 2019
@veewee veewee requested a review from Landerstraeten May 31, 2019 10:32
@mattheo-geoffray
Copy link

@veewee Hi, do you when the next release is planned?

@veewee
Copy link
Contributor Author

veewee commented Jun 3, 2019

Hi @mattheo-geoffray,

Sadly I discovered some broken scenario's when testing out conventions.
There are still some other scenario's well want to cover before releasing, since they will break BC.
In the meantime, you can check out master and use that one to verify if everything works for you.
You can also track progress in #644, but I am afraid I won't be able to work on that one very frequently.

@mattheo-geoffray
Copy link

@veewee Hi!
Oh OK no problem I will work with that one until it can be a stable release!
Thank you for the work! 🙂

@mattheo-geoffray
Copy link

Hi @veewee !
Do you have an idea for the release date of this PR?
Thanks!

@veewee
Copy link
Contributor Author

veewee commented Jul 23, 2019

Not yet, first have to find time to finish the pr above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants