-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESLint Task #774
Add ESLint Task #774
Conversation
- Add ESLint task for javascript code static analysis.. - Add ESLint test. - Add eslint.md instructions. - Update tasks.md to add link to instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It looks pretty good. I've added some small remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for feedback. I will add fixer and update unit test.
Wow, you reviewed this like right away, impressive as I submitted it at like 2am my time, lol.
- Simplify the formatErrorMessage() since it really only needs 2 strings, not an array. - Update the ESLintFormatterSpec to test result, instead of just that it gets a string back.
Thanks for your work. Really nice! |
Add ESLint task for javascript code static analysis (code quality and coding style).
As a good amount of php projects also have some javascript frontend, it's handy to lint your JS during pre-commit as well.
Example task run:
New Task Checklist:
run()
method readable?run()
method using the configuration correctly?