Fix the insertion of multiple domains as wildcard #3259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?
Fix #3257
When selecting the "Add domain as wildcard" checkbox with multiple domains, only the first one was changed into a wildcard regex.
How does this PR accomplish the above?
Changing
kind
variable from "exact" to "regex" only after the loop.The issue happened because the previous code were modifying this variable inside the loop, but after the first domain, the check failed (the kind was wrongly changed before all domains were parsed) and the rest of the domains were not changed into wildcards.
By submitting this pull request, I confirm the following:
git rebase
)