Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the insertion of multiple domains as wildcard #3259

Merged
merged 2 commits into from
Mar 2, 2025

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Fix #3257

When selecting the "Add domain as wildcard" checkbox with multiple domains, only the first one was changed into a wildcard regex.

How does this PR accomplish the above?

Changing kind variable from "exact" to "regex" only after the loop.

The issue happened because the previous code were modifying this variable inside the loop, but after the first domain, the check failed (the kind was wrongly changed before all domains were parsed) and the rest of the domains were not changed into wildcards.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign rdwebdesign requested a review from a team February 25, 2025 21:19
@rdwebdesign rdwebdesign requested a review from yubiuser February 26, 2025 17:25
@yubiuser yubiuser requested a review from DL6ER February 28, 2025 10:25
@rdwebdesign rdwebdesign merged commit ef74db8 into development Mar 2, 2025
11 checks passed
@rdwebdesign rdwebdesign deleted the fix/multiple_domains branch March 2, 2025 07:05
@PromoFaux PromoFaux mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants