Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's not possible to add multiple single file units to the same unit-type #15

Closed
Gummibeer opened this issue Feb 20, 2020 · 0 comments · Fixed by #16
Closed

It's not possible to add multiple single file units to the same unit-type #15

Gummibeer opened this issue Feb 20, 2020 · 0 comments · Fixed by #16

Comments

@Gummibeer
Copy link

Right now it's not possible to add multiple single file units to the same unittype.

UnitMap::add('Unit1.php', '\\MyUnits', Length::class);
UnitMap::add('Unit2.php', '\\MyUnits', Length::class);

The problem is

php-unit-conversion/src/Map.php

Line 101 in a12cdb3

self::$map = self::$map + $classes;

Instead of $array + $array it should use array_merge_recursive(). This will merge the arrays on the level they should get merged - the array of units in the unit-type.
@Gummibeer Gummibeer mentioned this issue Feb 20, 2020
Merged
@pimlie pimlie closed this as completed in #16 Mar 5, 2020
pimlie added a commit that referenced this issue Mar 5, 2020
@pimlie
fix: allow to add multiple single files to the same unit-type (#16)
e525057 
* add unittest for #15

* add fix for #15

* fix static/shared state between tests
pimlie added a commit that referenced this issue Mar 5, 2020
@pimlie
fix: allow to add multiple single files to the same unit-type (#16)
e158067 
* add unittest for #15

* add fix for #15

* fix static/shared state between tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to add multiple single files to the same unit-type
1 participant
@Gummibeer