Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EmbedParameters type to non-pointer #100

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

austin-denoble
Copy link
Contributor

Problem

While testing for v3 I noticed that we have a type for EmbedParameters that classifies it as a pointer. This isn't something we want for the type itself.

Solution

Clean up EmbedParameters.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

CI - unit & integration

@austin-denoble austin-denoble merged commit 2a9595c into main Feb 6, 2025
4 checks passed
@austin-denoble austin-denoble deleted the adenoble/fix-pointer-types branch February 6, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant