Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charset: make collation case insensitive #66

Merged
merged 2 commits into from
Dec 6, 2018
Merged

charset: make collation case insensitive #66

merged 2 commits into from
Dec 6, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Dec 4, 2018

fix pingcap/tidb#8304

before this PR, below case will failed.:

mysql> create table test(id int) ENGINE=InnoDB DEFAULT CHARSET=UTF8 COLLATE=UTF8_BIN;
ERROR 1115 (42000): Unknown character set: 'UTF8'

@kennytm kennytm changed the title charsert: make collation case insensitive charset: make collation case insensitive Dec 4, 2018
@winkyao winkyao mentioned this pull request Dec 4, 2018
Merged
@tiancaiamao
Copy link
Collaborator

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Dec 5, 2018
crazycs520
crazycs520 approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Dec 6, 2018
@winkyao winkyao merged commit b006f4e into pingcap:master Dec 6, 2018
@winkyao winkyao deleted the case_insensitive_collate branch December 6, 2018 12:32
winkyao added a commit to winkyao/parser that referenced this pull request Dec 6, 2018
@winkyao
charsert: make collation case insensitive (pingcap#66)
3f05cc1
@winkyao winkyao mentioned this pull request Dec 6, 2018
Merged
jackysp pushed a commit that referenced this pull request Dec 7, 2018
@winkyao @jackysp
charsert: make collation case insensitive (#66) (#70)
6c21d43
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@winkyao
charsert: make collation case insensitive (pingcap#66)
c12d5bc
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@winkyao
charsert: make collation case insensitive (pingcap#66)
84a6ec9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Character set name is case sensitive in TiDB
4 participants
@winkyao @tiancaiamao @crazycs520 @kennytm