Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recover and Daemon Thread to key background tasks #58738

Closed
hawkingrei opened this issue Jan 7, 2025 · 0 comments · Fixed by #58739
Closed

Add recover and Daemon Thread to key background tasks #58738

hawkingrei opened this issue Jan 7, 2025 · 0 comments · Fixed by #58739
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

Enhancement

#58715 bug will panic in the background. it will make this background exiting and cannot restart it. it will lead many critical bug. so we need to add recover to avoid panic exit and it happen the panic, we need to restart this background.
@hawkingrei hawkingrei added the type/enhancement The issue or PR belongs to an enhancement. label Jan 7, 2025
@hawkingrei hawkingrei mentioned this issue Jan 7, 2025
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 23ed0df Jan 7, 2025
This was referenced Jan 7, 2025
Merged
Open
Merged
Open
Merged
@ti-chi-bot ti-chi-bot bot added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Jan 8, 2025
ti-chi-bot bot pushed a commit that referenced this issue Jan 8, 2025
@ti-chi-bot
statistics: add recover to protect background task (#58739) (#58767)
1d198e6 
close #58738
@jebter jebter added the sig/planner SIG: Planner label Jan 24, 2025
ti-chi-bot bot pushed a commit that referenced this issue Feb 5, 2025
@ti-chi-bot
statistics: add recover to protect background task (#58739) (#58763)
73082a2 
close #58738
ti-chi-bot bot pushed a commit that referenced this issue Feb 14, 2025
@ti-chi-bot
statistics: add recover to protect background task (#58739) (#58765)
bf811e4 
close #58738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statistics: add recover to protect background task hawkingrei/tidb
2 participants
@hawkingrei @jebter