Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix bootstrap panic when upgrading to master (#56517) #56616

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56517

What problem does this PR solve?

Issue Number: close #56489

Problem Summary:

What changed and how does it work?

ctx is nil and it panic here:

if opt := ctx.Value(refillOptionKey); opt != nil {
refill = opt.(bool)
}

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Follow the upgrade steps described in the issue

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4 labels Oct 12, 2024
@tiancaiamao tiancaiamao requested review from lance6716 and D3Hunter and removed request for lance6716 October 12, 2024 09:19
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.4@8516d55). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.4     #56616   +/-   ##
================================================
  Coverage               ?   56.2198%           
================================================
  Files                  ?       1751           
  Lines                  ?     628051           
  Branches               ?          0           
================================================
  Hits                   ?     353089           
  Misses                 ?     251071           
  Partials               ?      23891           
Flag Coverage Δ
integration 36.8418% <82.3529%> (?)
unit 72.4790% <88.2352%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.3902% <0.0000%> (?)

@tiancaiamao
Copy link
Contributor

/test check-dev2

Copy link

tiprow bot commented Oct 12, 2024

@tiancaiamao: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiancaiamao
Copy link
Contributor

/test check-dev2

Copy link

tiprow bot commented Oct 12, 2024

@tiancaiamao: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
Copy link

ti-chi-bot bot commented Oct 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-12 09:20:53.23218284 +0000 UTC m=+90050.381092664: ☑️ agreed by lance6716.
  • 2024-10-14 02:50:08.848991041 +0000 UTC m=+239405.997900873: ☑️ agreed by yudongusa.

@ti-chi-bot ti-chi-bot bot merged commit db318b8 into pingcap:release-8.4 Oct 14, 2024
18 checks passed
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants