-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: fix bootstrap panic when upgrading to master (#56517) #56616
session: fix bootstrap panic when upgrading to master (#56517) #56616
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.4 #56616 +/- ##
================================================
Coverage ? 56.2198%
================================================
Files ? 1751
Lines ? 628051
Branches ? 0
================================================
Hits ? 353089
Misses ? 251071
Partials ? 23891
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check-dev2 |
@tiancaiamao: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test check-dev2 |
@tiancaiamao: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #56517
What problem does this PR solve?
Issue Number: close #56489
Problem Summary:
What changed and how does it work?
ctx is nil and it panic here:
tidb/pkg/infoschema/infoschema_v2.go
Lines 625 to 627 in 1eb0c8c
Check List
Tests
Follow the upgrade steps described in the issue
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.