-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: convert cartesian semi join with other nulleq condition to cross semi join with equal condition #58075
Conversation
6a05f0c
to
51eac5b
Compare
/test all |
/retest |
2 similar comments
/retest |
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58075 +/- ##
================================================
+ Coverage 73.2259% 75.0601% +1.8341%
================================================
Files 1675 1724 +49
Lines 462254 470664 +8410
================================================
+ Hits 338490 353281 +14791
+ Misses 102989 95249 -7740
- Partials 20775 22134 +1359
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/check-issue-triage-complete |
db4789a
to
28233bb
Compare
can you explain why the original positive case normally work even without this fix
|
…oin with other condition
Signed-off-by: Weizhen Wang <[email protected]>
/retest |
In fact, it skipes the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-8.5 |
Signed-off-by: ti-chi-bot <[email protected]>
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #57583
Problem Summary:
What changed and how does it work?
when to convert the equal condition, We only consider the equality condition. but nulleq is considered,too.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.