-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add window function NTILE #9682
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b4ebcd4
executor: add window function NTILE
winoros 42f0522
address comments
winoros 8e67747
fix unit-test
winoros 8d262cb
remove unused char
winoros 6cb888c
address comments
winoros 0bb8c2c
Merge branch 'master' into window-ntile
winoros f9ba80b
Merge branch 'master' into window-ntile
zz-jason File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
// Copyright 2019 PingCAP, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package aggfuncs | ||
|
||
import ( | ||
"github.com/pingcap/tidb/sessionctx" | ||
"github.com/pingcap/tidb/util/chunk" | ||
) | ||
|
||
// ntile divides the partition into n ranked groups and returns the group number a row belongs to. | ||
// e.g. We have 11 rows and n = 3. They will be divided into 3 groups. | ||
// First 4 rows belongs to group 1. Following 4 rows belongs to group 2. The last 3 rows belongs to group 3. | ||
type ntile struct { | ||
n uint64 | ||
baseAggFunc | ||
} | ||
|
||
type partialResult4Ntile struct { | ||
curIdx uint64 | ||
divisor uint64 | ||
curGroupIdx uint64 | ||
remainder uint64 | ||
quotient uint64 | ||
rows []chunk.Row | ||
} | ||
|
||
func (n *ntile) AllocPartialResult() PartialResult { | ||
return PartialResult(&partialResult4Ntile{divisor: n.n, curGroupIdx: 1}) | ||
} | ||
|
||
func (n *ntile) ResetPartialResult(pr PartialResult) { | ||
p := (*partialResult4Ntile)(pr) | ||
p.curIdx = 0 | ||
p.curGroupIdx = 1 | ||
p.rows = p.rows[:0] | ||
} | ||
|
||
func (n *ntile) UpdatePartialResult(_ sessionctx.Context, rowsInGroup []chunk.Row, pr PartialResult) error { | ||
p := (*partialResult4Ntile)(pr) | ||
p.rows = append(p.rows, rowsInGroup...) | ||
// Update the quotient and remainder. | ||
if p.divisor != 0 { | ||
p.quotient = uint64(len(p.rows)) / p.divisor | ||
p.remainder = uint64(len(p.rows)) % p.divisor | ||
} | ||
return nil | ||
} | ||
|
||
func (n *ntile) AppendFinalResult2Chunk(_ sessionctx.Context, pr PartialResult, chk *chunk.Chunk) error { | ||
p := (*partialResult4Ntile)(pr) | ||
|
||
// If the divisor is 0, the arg of NTILE would be NULL. So we just return NULL. | ||
if p.divisor == 0 { | ||
chk.AppendNull(n.ordinal) | ||
return nil | ||
} | ||
|
||
chk.AppendUint64(n.ordinal, p.curGroupIdx) | ||
|
||
p.curIdx++ | ||
curMaxIdx := p.quotient | ||
if p.curGroupIdx <= p.remainder { | ||
curMaxIdx++ | ||
} | ||
if p.curIdx == curMaxIdx { | ||
p.curIdx = 0 | ||
p.curGroupIdx++ | ||
} | ||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it needed? Can we just use the
n
inntile
?