Refine window when preceding and following boundary type are unbounded #9916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/L
ti-chi-bot
bot
added
size/XL
windtalker
reviewed
Mar 7, 2025
|
|
||
| has_shortcut = window_description_.frame.begin_type == WindowFrame::BoundaryType::Unbounded | ||
| && window_description_.frame.end_type == WindowFrame::BoundaryType::Unbounded | ||
| && !aggregation_workspaces.empty(); |
There was a problem hiding this comment.
and window_workspaces should be empty?
| @@ -292,6 +295,9 @@ void WindowTransformAction::initialWorkspaces() | |||
| } | |||
| } | |||
|
|
|||
| // Can not have window and agg functions together in one window | |||
| assert((!aggregation_workspaces.empty() && !window_workspaces.empty()) == false); | |||
There was a problem hiding this comment.
why have this restriction?
| Block WindowTransformAction::tryGetOutputBlock() | ||
| { | ||
| // first try calculate the result based on current data | ||
| tryCalculate(); | ||
| if (window_description.need_decrease) |
There was a problem hiding this comment.
if need_decrease is true, has_shortcut should always be false?
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9913
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note