vector: Fix the bug that the local index in CFTiny is not removed during MinorCompaction (#9945) #9951
+270
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9945
What problem does this PR solve?
Issue Number: close #9946
Problem Summary:
Some pages for local index in the ColumnFileTiny is not removed when doing MinorCompaction
tiflash/dbms/src/Storages/DeltaMerge/Delta/MinorCompaction.cpp
Lines 53 to 54 in 6fec03d
In
MinorCompaction::prepare
we usewbs.removed_log.delPage(t_file->getDataPageId());
to remove the ColumnFileTiny. But this will not remove the related LocalIndex page_id with the ColumnFileTiny. We must uset_file->removeData(wbs);
to remove the ColumnFileTiny along with its LocalIndex page_ids.BTW,
SegmentSplit
,SegmentMerge
andSegmentDeltaMerge
(MajorCompaction) callsDeltaValueSpace::recordRemoveColumnFilesPages
and can correctly remove the LocalIndex page_ids.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note