Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbt-native-packager doesn't copy configuration when play plugin is enabled #4242

Closed
zlangbert opened this issue Apr 15, 2015 · 5 comments · Fixed by #4251
Closed

sbt-native-packager doesn't copy configuration when play plugin is enabled #4242

zlangbert opened this issue Apr 15, 2015 · 5 comments · Fixed by #4251

Comments

@zlangbert
Copy link

The sbt-native-packager docs say here that you can create an application.ini in src/universal/conf and it will process it and put it in the app's conf directory. When the play plugin is enabled this file does not end up in the conf directory. The sbt guys said this seems to be a problem with play.

https://github.com/Kyprus/sbt-native-packager-test demonstrates the issue
@huntc
Copy link
Contributor

huntc commented Apr 16, 2015

I suspect that this is 1.0.0 of the native packager as I think application.ini was added there. You should be able to use mappings as a work-around, but Play may need to take care of this in 2.4.

@zlangbert
Copy link
Author

Yes, this is in 1.0.0 and play 2.4-M3. Should have mentioned that, sorry.

@huntc I'm not sure what you mean, which mappings?

@jroper
Copy link
Member

jroper commented Apr 16, 2015

The native packager source directory in Play is the dist directory, not src/universal. So put your file in dist/conf.

@zlangbert
Copy link
Author

@jroper Thanks! That worked. Also I noticed in the latest play docs (master) it says to put it in src/universal/conf/ so that should probably be updated?

jroper added a commit to jroper/playframework that referenced this issue Apr 16, 2015
@jroper
Documented the dist folder
3543c10 
Fixes playframework#4242

Also moved configuration of the dist folder to the PlayLayoutPlugin,
so that if disabled, it will revert to the standard `src/universal`.
@jroper jroper mentioned this issue Apr 16, 2015
Merged
@jroper
Copy link
Member

jroper commented Apr 16, 2015

Pull request here: #4251

jroper added a commit to jroper/playframework that referenced this issue Apr 16, 2015
@jroper
Documented the dist folder
01922a4 
Fixes playframework#4242

Also moved configuration of the dist folder to the PlayLayoutPlugin,
so that if disabled, it will revert to the standard `src/universal`.
jroper added a commit to jroper/playframework that referenced this issue Apr 16, 2015
@jroper
Documented the dist folder
25a55c7 
Fixes playframework#4242

Also moved configuration of the dist folder to the PlayLayoutPlugin,
so that if disabled, it will revert to the standard `src/universal`.
jroper added a commit to jroper/playframework that referenced this issue Apr 17, 2015
@jroper
Documented the dist folder
e72a20f 
Fixes playframework#4242

Also moved configuration of the dist folder to the PlayLayoutPlugin,
so that if disabled, it will revert to the standard `src/universal`.
@zlangbert zlangbert mentioned this issue Apr 17, 2015
Closed
ClaraAllende pushed a commit to ClaraAllende/playframework that referenced this issue Aug 28, 2015
@jroper
Documented the dist folder
8e4fd49 
Fixes playframework#4242

Also moved configuration of the dist folder to the PlayLayoutPlugin,
so that if disabled, it will revert to the standard `src/universal`.
@martinstuder martinstuder mentioned this issue Apr 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Documented the dist folder jroper/playframework
3 participants
@jroper @zlangbert @huntc