Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.6.x] Scalameta parsers 4.13.2 - no more for3Use2_13 workaround (backport #904) by @mkurz #905

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 23, 2025

I looked into the scalameta parsers projects - it should be ok to just upgrade to the latest version as long as our tests pass.

Also good thing is that we can now also use the native Scala 3 artifact and starting with 4.9.9 (which we ship in latest twirl) parsers does not depend on protobuf-java anyomore which has vulnerabilities.


This is an automatic backport of pull request #904 done by Mergify.

@mergify mergify bot added the conflicts label Feb 23, 2025
Copy link
Contributor Author

mergify bot commented Feb 23, 2025

Cherry-pick of 27fc406 has failed:

On branch mergify/bp/1.6.x/pr-904
Your branch is up to date with 'origin/1.6.x'.

You are currently cherry-picking commit 27fc406.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   build.sbt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

(cherry picked from commit 27fc406)

# Conflicts:
#	build.sbt
@mkurz mkurz force-pushed the mergify/bp/1.6.x/pr-904 branch from df8e4c1 to 6df86a0 Compare February 23, 2025 17:43
@mkurz mkurz changed the title [1.6.x] [2.0.x] Scalameta parsers 4.13.2 - no more for3Use2_13 workaround (backport #904) by @mkurz [1.6.x] Scalameta parsers 4.13.2 - no more for3Use2_13 workaround (backport #904) by @mkurz Feb 23, 2025
@mkurz mkurz merged commit 3e5e8d0 into 1.6.x Feb 23, 2025
17 checks passed
@mkurz mkurz deleted the mergify/bp/1.6.x/pr-904 branch February 23, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant