Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goreleaser to publish binaries #579

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Feb 11, 2025

Replaces the manual release process with goreleaser + github actions.

@mrueg mrueg force-pushed the goreleaser branch 3 times, most recently from 6d1c724 to ee9c482 Compare February 17, 2025 13:26
@mrueg
Copy link
Contributor Author

mrueg commented Feb 17, 2025

@jalseth I rebased it, this should be good to go now.

Copy link
Collaborator

@jalseth jalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

@@ -0,0 +1,25 @@
name: publish-binaries
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a part of the existing tag workflow? Would be nice to have the Github release created via tag along with the container pushes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I updated it and use https://github.com/ncipollo/release-action (ideally would have used https://github.com/actions/create-release but that's unmaintained)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think GoReleaser creates the Github release automatically. It does on the conftest repo without any other GH actions.

https://github.com/open-policy-agent/conftest/blob/master/.github/workflows/release.yaml#L49

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point. I made the changes.

@mrueg mrueg force-pushed the goreleaser branch 2 times, most recently from f767c31 to 6ebf50f Compare February 24, 2025 08:32
@jalseth jalseth merged commit 2b6879d into plexsystems:main Mar 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants