-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add goreleaser to publish binaries #579
Conversation
6d1c724
to
ee9c482
Compare
@jalseth I rebased it, this should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on!
@@ -0,0 +1,25 @@ | |||
name: publish-binaries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be a part of the existing tag workflow? Would be nice to have the Github release created via tag along with the container pushes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I updated it and use https://github.com/ncipollo/release-action (ideally would have used https://github.com/actions/create-release but that's unmaintained)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think GoReleaser creates the Github release automatically. It does on the conftest repo without any other GH actions.
https://github.com/open-policy-agent/conftest/blob/master/.github/workflows/release.yaml#L49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point. I made the changes.
f767c31
to
6ebf50f
Compare
Replaces the manual release process with goreleaser + github actions.