Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint/improve YAML in policies docs #581

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

zephyrdb
Copy link
Contributor

@zephyrdb zephyrdb commented Feb 12, 2025

All of the unordered lists should use asterisks for consistency. It's also harder to confuse them with YAML arrays. There are also two cases in which YAML embedded in a src.rego file causes lint warnings in the output. The rest of the template changes fix various cases in which there are two consecutive blank lines.

@zephyrdb zephyrdb force-pushed the better-yaml branch 3 times, most recently from 7d6e679 to 9ade074 Compare February 19, 2025 22:45
Copy link
Collaborator

@jalseth jalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll merge once the conflicts are resolved.

@zephyrdb
Copy link
Contributor Author

Thanks. I know there was one recently, but any chance of getting a release that includes these?

@jalseth jalseth merged commit bd72b29 into plexsystems:main Feb 25, 2025
11 checks passed
@jalseth
Copy link
Collaborator

jalseth commented Feb 25, 2025

It's close to the end of the month where OPA will release a new version which is the cadence I try to follow.

@zephyrdb zephyrdb deleted the better-yaml branch February 25, 2025 16:25
@zephyrdb
Copy link
Contributor Author

Sounds good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants