Fix constraint template #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add tests so this error doesn't get introduced again? |
|
Sure I'll add tests, I haven't fully understood why it worked here and didn't work when I used only partial matchers. |
|
I added a few more acceptance tests that hopefully cover more cases, unfortunately I wasn't able to reproduce the failure anymore. I think it's still better to use the matchers directly. |
mrueg
force-pushed
the
fix-template
branch
2 times, most recently
from
2514b99 to
2a147cb
Compare
jalseth
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetAnnotation didn't work as expected and threw an error if the matchers key wasn't available. This works better.
The parameters here didn't make sense so I excluded them.