Compatibility with incoming ggplot2 changes #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I very much appreciate it -- well done, thank you!! |
|
Hi @cpsievert, we're aiming for a ggplot2 release before summer (around May). I'd be swell if there'd be a compatible plotly version out around that time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Carson and other maintainers,
Apologies for the cold PR!
While building a new feature in ggplot2 we found through reverse dependency checks that {plotly} was negatively affected by the changes we'd like to implement. The new feature makes extensive use of computed values in the
Geom$default_aesfield, contrasted by mostly fixed values in the current CRAN version. Mostly, this PR resolves the relevant defaults before using them in {plotly}. The changes herein should be backwards compatible (locally tested with ggplot2 3.5.1).In addition, a small change with regards to label setup is sneaked in for good measure.
If you rather have a separate PR for that I'll prepare one.
We don't intend to release a new version of ggplot2 this year, so there isn't much of a hurry to merge this.