Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): update clog to allow setting a tag date #1278

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Conversation

wyze
Copy link
Contributor

@wyze wyze commented Nov 13, 2020

Close #1277


If you check the referenced ticket, I point to the code where the date is always set to the current date. I pulled down the code and made the changes needed to support the date.

Looks like this also changed the order of Features/Bug Fixes sections and added colons to the component names.

I've updated this to also run on publish so it should get generated when a new version is released.

Alternatively, we could look at something else to generate these like https://github.com/conventional-changelog/conventional-changelog, but the output might not be exactly the same. Seems clog hasn't received updates in some time.

@wyze wyze requested a review from plouc November 13, 2020 21:48
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 53e5f4e:

Sandbox Source
nivo Configuration
nivo-website Configuration

@plouc
Copy link
Owner

plouc commented Nov 16, 2020

Yes, this issue is annoying, I don't think we should include the tool directly into the repo though, I'd prefer to find another tool, even if the output is slightly different.

@wyze
Copy link
Contributor Author

wyze commented Nov 16, 2020

Okay, that works for me. I will evaluate a few and see which ones work best and update the PR, maybe with a few samples.

@wyze
Copy link
Contributor Author

wyze commented Nov 17, 2020

@plouc Should be good to go now. I'd like to squash this into a single commit on merge.

@wyze wyze changed the title fix(changelog): vendor clog and allow setting a tag date fix(changelog): update clog to allow setting a tag date Nov 17, 2020
@wyze wyze requested a review from plouc November 17, 2020 14:08
Copy link
Owner

@plouc plouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plouc plouc merged commit e984d72 into master Nov 17, 2020
@plouc plouc deleted the vendor-clog branch November 17, 2020 14:10
ddavydov pushed a commit to netronixgroup/nivo that referenced this pull request Apr 8, 2021
* fix(changelog): vendor clog and allow setting a tag date

* chore(changelog): switch to standard-version

* chore(changelog): switch to my forked clog package

* docs(changelog): add comments to changelog script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All release dates in CHANGELOG are the same
2 participants