Invalid markup by AMP plugin with enabled JavaScript tracking

[MatzeKitt]

Every time I save a post I get two validation errors in the official AMP plugin with enabled JavaScript tracking:

Invalid inline script
Fehlercode
DISALLOWED_TAG
Ungültiges Markup

<script … > Element-Attribute type text/javascript id statify-js-js-extra Element-Name script Übergeordnetes Element body Textinhalt 128 Bytes /* */

Invalid script snippet.min.js
Fehlercode
DISALLOWED_TAG
Ungültiges Markup

<script … > Element-Attribute type text/javascript src https://kittmedia.com/wp-content/plugins/statify/js/snippet.min.js id statify-js-js Element-Name script Übergeordnetes Element body

Due to the fact that Statify is recommending using the JavaScript tracking method to track AMP pages as well, I would assume that it will work properly. However, as soon as this invalid markup gets removed (which is required in order to serve AMP pages), Statify isn’t able anymore to track any AMP page visits.

AMP version: 2.0.0 (already occurred in version 1.5.x)
Statify version: 1.8.0
WordPress version: 5.5.0

[Zodiac1978]

Related #110 and #116

[stklcode]

That's right, we always include the JS, if JS-Tracking is enabled:

statify/inc/class-statify-frontend.php

Lines 387 to 403 in a775618

	wp_enqueue_script(
	'statify-js',
	plugins_url( 'js/snippet.min.js', STATIFY_FILE ),
	array(),
	STATIFY_VERSION,
	true
	);
	// Add endpoint to script.
	wp_localize_script(
	'statify-js',
	'statify_ajax',
	array(
	'url' => admin_url( 'admin-ajax.php' ),
	'nonce' => wp_create_nonce( 'statify_track' ),
	)
	);

Statify isn’t able anymore to track any AMP page visits.

Are you sure it isn't?

We do have the amp_post_template_analytics() method to register a separate analysis hook:

statify/inc/class-statify-frontend.php

Line 413 in a775618

public static function amp_post_template_analytics( $analytics ) {

The script tag is removed from AMP markup, but that should be OK here. Otherwise we would track twice.
So if visits are not tracked, it's not because the script is removed, but likely for a different reason.

Nevertheless we should not include it at all, if we are processing an AMP request to remove the unnecessary warning.

[MatzeKitt]

Are you sure it isn’t?

Yes, I am.

Visiting https://kittmedia.com as guest adds an entry in the database table of Statify, visiting https://kittmedia.com/?amp does not.

[stklcode]

OK, I got the point. In fact we got 2 problems here:

1. the invalid markup due to the unnecessary <script> tags
   => Simple solution, don't add the snippet on AMP requests
2. We use the amp_post_template_analytics hook, which is only available in Reader Mode
   => Additionally hook into amp_analytics_entries for Standard/transitional Mode (cave: different data model)