fix: micro-suspenses #3013
Open
fix: micro-suspenses #3013
+58
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tien
commented
Mar 6, 2025
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/CKNELUEEV |
See documentations for usage instructions.
dmaskasky
reviewed
Mar 6, 2025
src/react/useAtomValue.ts
Outdated
Comment on lines
141
to
149
| const value = store.get(atom) | ||
| if (isPromiseLike(value)) { | ||
| attachPromiseMeta(createContinuablePromise(value)) | ||
| } | ||
|
|
There was a problem hiding this comment.
So it seems to work when we add a microtask delay.
Can we avoid having to add a delay?
There was a problem hiding this comment.
As per this issue: #2848
Adding a delay is actually a workaround for a React 19 specific bug.
Though when I test around with it, seems like this is the actual part that fix it attachPromiseMeta(createContinuablePromise(value))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2848
I honestly don't understand why or how, so would need help with reviewing this. Worth noting this issue only happen with React 19.