Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs/typescript): provide example how to use middlewares with #1565 #1578

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

holgergp
Copy link
Contributor

Related Issues

#1565

Fixes #.

Summary

Providing an example of using middlewares with vanilla stores using typescript

Check List

  • yarn run prettier for formatting code and docs

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0ee7224:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

Copy link
Collaborator

@sewera sewera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe linking to the section, so that it's available both on Github, and in the rendered https://docs.pmnd.rs/zustand/guides/typescript#basic-usage is a better idea.

Linking to section

Co-authored-by: Blazej Sewera <[email protected]>
Copy link
Collaborator

@sewera sewera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for commit mention :)

@holgergp
Copy link
Contributor Author

@sewera NP :)
This was the inline GH "apply suggestion" workflow. Apparently it generates a co-author. 🤷 Which is nice! 😀

@dai-shi dai-shi merged commit 04080fd into pmndrs:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants