Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docs readability #1931

Merged
merged 7 commits into from
Jul 13, 2023
Merged

improve docs readability #1931

merged 7 commits into from
Jul 13, 2023

Conversation

mohammedmulazada
Copy link
Contributor

Summary

Had a look at the docs and made a few changes that I feel like make it easier to find stuff or read. For example I didn't immediately understand what the zustand mock enabled, or the renderCounter function being at the bottom of one of the codeblocks confused me for a little bit.

Check List

  • yarn run prettier for formatting code and docs

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 12, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 43a7b33:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

@dai-shi dai-shi requested review from sewera and dbritto-dev July 12, 2023 23:56
Copy link
Collaborator

@sewera sewera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor nitpicks, looks good to me, good job :)

@mohammedmulazada
Copy link
Contributor Author

@sewera thanks for the feedback! I went ahead and implemented them right away, please have another look if you have time :)

@dai-shi dai-shi merged commit f73736d into pmndrs:main Jul 13, 2023
@mohammedmulazada mohammedmulazada deleted the patch-1 branch July 13, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants