Extends 'spo list get' command with support for retrieving any default list in a given site #6447

tmaestrini · 2024-10-22T21:23:53Z

Closes #5856.

This PR substitutes PR #6445

milanholemans · 2024-10-22T21:31:54Z

Thanks, we'll have a look at it ASAP.

Adam-it · 2024-10-29T10:40:00Z

@tmaestrini I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

tmaestrini · 2024-11-02T07:51:43Z

@Adam-it Thanks a lot! :) Looking forward to my very first contribution on the M365 cli when this PR gets closed! ;)

tmaestrini · 2024-11-06T22:07:26Z

Do you want me to do something on this? Is there anything missing?

Adam-it · 2024-11-07T06:52:20Z

Do you want me to do something on this? Is there anything missing?

@tmaestrini I don't think there is anything missing. We have a lot of PRs to process but we will try to catch up with this ASAP

milanholemans

Nice work @tmaestrini, I suggest we make some minor changes.

src/m365/spo/commands/list/list-get.ts

src/m365/spo/commands/list/list-get.spec.ts

…ed when no id, title, or url is provided; update tests to reflect changes

…point is used

…retrieval and check again if the right url was passed

tmaestrini · 2024-12-26T23:34:01Z

@milanholemans, I guess we're good to go now. Have another review! 🙌

milanholemans · 2025-01-19T21:23:54Z

@tmaestrini, did you find some time to implement the needed changes?

tmaestrini · 2025-01-19T22:07:25Z

Hey @milanholemans, not yet – sorry! Will do the changes mentioned in #5856 (comment) within the next days…

DefaultDocumentLibrary, change validation of properties

the command documentation

tmaestrini · 2025-02-02T21:36:54Z

Hey @milanholemans, ready to review? I've implemented the changes for the --default command option as requested in #5856.

milanholemans · 2025-02-02T21:44:26Z

Seems like some test broke @tmaestrini, could you take a look at it?

tmaestrini · 2025-02-02T22:23:30Z

Done! Fixed the typo in the options definition… 🤦🏻‍♂️ Sorry for that.

milanholemans

Nice work, let's modify a few things before we merge it.

milanholemans · 2025-02-23T21:28:45Z

src/m365/spo/commands/list/list-get.ts

@@ -35,7 +36,7 @@ class SpoListGetCommand extends SpoCommand {
  }

  public get description(): string {
-    return 'Gets information about the specific list';
+    return 'Gets information about the specific list or returns information about the default list in a site';


Let's not modify the description.

milanholemans · 2025-02-23T21:29:19Z

src/m365/spo/commands/list/list-get.ts

@@ -54,7 +55,8 @@ class SpoListGetCommand extends SpoCommand {
        title: (!(!args.options.title)).toString(),
        url: (!(!args.options.url)).toString(),
        properties: (!(!args.options.properties)).toString(),
-        withPermissions: typeof args.options.withPermissions !== 'undefined'
+        withPermissions: typeof args.options.withPermissions !== 'undefined',
+        default: typeof args.options.default !== 'undefined'


Suggested change

default: typeof args.options.default !== 'undefined'

default: !!args.options.default

milanholemans · 2025-02-23T21:47:20Z

docs/docs/cmd/spo/list/list-get.mdx

+: Server- or site-relative URL of the list. Specify either `id`, `title`,`url` or `default` but not multiple.
+
+`--default`
+: Set if you want to return the default list from the site. Specify either `id`, `title`, `url` or `default` but not multiple.


Suggested change

: Set if you want to return the default list from the site. Specify either `id`, `title`, `url` or `default` but not multiple.

: Set to retrieve the default list from the site. Specify either `id`, `title`, `url`, or `default` but not multiple.

milanholemans · 2025-02-23T21:47:44Z

docs/docs/cmd/spo/list/list-get.mdx

+Get the default document library located in the specified site.
+
+```sh
+m365 spo list get --webUrl https://contoso.sharepoint.com/sites/project-x


Suggested change

m365 spo list get --webUrl https://contoso.sharepoint.com/sites/project-x

m365 spo list get --webUrl https://contoso.sharepoint.com/sites/project-x --default

milanholemans · 2025-02-23T21:48:22Z

docs/docs/cmd/spo/list/list-get.mdx

+Get information about the default (document) located in the specified site.
+
+```sh
+m365 spo list get --webUrl https://contoso.sharepoint.com/sites/project-x --default


Let's not use the same example twice.

milanholemans · 2025-03-10T22:23:22Z

Hi @tmaestrini, just checking if you had some time to look at my feedback yet. No problem if you need a couple more weeks.

tmaestrini · 2025-03-14T23:19:09Z

Hi @milanholemans, thanks for asking.
Currently, I'm pretty busy, so I'll take care of everything after the MVP summit.

milanholemans · 2025-03-14T23:20:09Z

Sure no problem! Thanks for letting us know.

Tobias Maestrini added 7 commits October 22, 2024 23:06

remove option set dependency to reduce mandatory options

9d03ab7

change description

8dc09f5

change option selectors to retrieve default document library

3e5c95f

add test

fc794ce

fix test to correct action parameters due to missing code coverage

ff5a49d

change personal information

e7c730e

fix typo

04d5137

tmaestrini changed the title ~~5856 retrieve default list in site~~ Extends 'spo list get' command with support for retrieving any default list in a given site Oct 22, 2024

Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2024

milanholemans self-assigned this Dec 8, 2024

milanholemans requested changes Dec 8, 2024

View reviewed changes

milanholemans marked this pull request as draft December 8, 2024 23:12

Tobias Maestrini added 4 commits December 26, 2024 00:51

add documentation for default call

ed73400

refactor list-get command to ensure DefaultDocumentLibrary is request…

c9b59fe

…ed when no id, title, or url is provided; update tests to reflect changes

update URL check for DefaultDocumentLibrary to verify the correct end…

6eaee7c

…point is used

refactor test to use proper mock response for DefaultDocumentLibrary …

5959d06

…retrieval and check again if the right url was passed

tmaestrini marked this pull request as ready for review December 26, 2024 23:32

milanholemans marked this pull request as draft January 3, 2025 21:33

Tobias Maestrini added 3 commits February 2, 2025 22:23

add 'default' option to command and for retrieving

8298499

DefaultDocumentLibrary, change validation of properties

add 'default' option and an according example to

585a2e7

the command documentation

add 'default' option to list-get command test

c29f8e2

tmaestrini marked this pull request as ready for review February 2, 2025 21:37

milanholemans marked this pull request as draft February 2, 2025 21:44

fix typo in list-get command test option

2b8a86d

tmaestrini marked this pull request as ready for review February 2, 2025 22:22

milanholemans requested changes Feb 23, 2025

View reviewed changes

milanholemans marked this pull request as draft February 23, 2025 21:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extends 'spo list get' command with support for retrieving any default list in a given site #6447

Extends 'spo list get' command with support for retrieving any default list in a given site #6447

tmaestrini commented Oct 22, 2024

milanholemans commented Oct 22, 2024

Adam-it commented Oct 29, 2024

tmaestrini commented Nov 2, 2024

tmaestrini commented Nov 6, 2024

Adam-it commented Nov 7, 2024

milanholemans left a comment

tmaestrini commented Dec 26, 2024

milanholemans commented Jan 19, 2025

tmaestrini commented Jan 19, 2025 •

edited

Loading

tmaestrini commented Feb 2, 2025

milanholemans commented Feb 2, 2025

tmaestrini commented Feb 2, 2025 •

edited

Loading

milanholemans left a comment

milanholemans Feb 23, 2025

milanholemans Feb 23, 2025

milanholemans Feb 23, 2025

milanholemans Feb 23, 2025

milanholemans Feb 23, 2025

milanholemans commented Mar 10, 2025

tmaestrini commented Mar 14, 2025

milanholemans commented Mar 14, 2025

	default: typeof args.options.default !== 'undefined'
	default: !!args.options.default

	: Set if you want to return the default list from the site. Specify either `id`, `title`, `url` or `default` but not multiple.
	: Set to retrieve the default list from the site. Specify either `id`, `title`, `url`, or `default` but not multiple.

	m365 spo list get --webUrl https://contoso.sharepoint.com/sites/project-x
	m365 spo list get --webUrl https://contoso.sharepoint.com/sites/project-x --default

Extends 'spo list get' command with support for retrieving any default list in a given site #6447

Are you sure you want to change the base?

Extends 'spo list get' command with support for retrieving any default list in a given site #6447

Conversation

tmaestrini commented Oct 22, 2024

milanholemans commented Oct 22, 2024

Adam-it commented Oct 29, 2024

tmaestrini commented Nov 2, 2024

tmaestrini commented Nov 6, 2024

Adam-it commented Nov 7, 2024

milanholemans left a comment

Choose a reason for hiding this comment

tmaestrini commented Dec 26, 2024

milanholemans commented Jan 19, 2025

tmaestrini commented Jan 19, 2025 • edited Loading

tmaestrini commented Feb 2, 2025

milanholemans commented Feb 2, 2025

tmaestrini commented Feb 2, 2025 • edited Loading

milanholemans left a comment

Choose a reason for hiding this comment

milanholemans Feb 23, 2025

Choose a reason for hiding this comment

milanholemans Feb 23, 2025

Choose a reason for hiding this comment

milanholemans Feb 23, 2025

Choose a reason for hiding this comment

milanholemans Feb 23, 2025

Choose a reason for hiding this comment

milanholemans Feb 23, 2025

Choose a reason for hiding this comment

milanholemans commented Mar 10, 2025

tmaestrini commented Mar 14, 2025

milanholemans commented Mar 14, 2025

tmaestrini commented Jan 19, 2025 •

edited

Loading

tmaestrini commented Feb 2, 2025 •

edited

Loading