Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes defaultProperties method from various commands. Closes #6432 #6560

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removes defaultProperties method from various commands. Closes #6432 #6560

wants to merge 2 commits into from

Conversation

SmitaNachan
Copy link
Contributor

Removes defaultProperties method from various commands. Closes #6432

@SmitaNachan SmitaNachan mentioned this pull request Jan 13, 2025
Closed
Adam-it
Adam-it approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't worry about the conflicts I will resolve it when merging
I also noticed website get and sitedesign run status get that have default props. I will try to sort it out when merging

@Adam-it
Copy link
Member

Adam-it commented Feb 7, 2025

Ready to merge 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove defining default properties from commands that are not returning a list
2 participants
@SmitaNachan @Adam-it