New command: m365 graph openextension add. Closes #6627 #6650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, we'll try to check it soon. |
martinlingstuyl
requested changes
Mar 14, 2025
| m365 graph openextension add --resourceId eb77fbcf-6fe8-458b-985d-1747284793bc --resourceType group --name 'com.contoso.roamingSettings' --settings '{"theme": "dark", "color": "red", "language": "English"}' --supportedSystem 'Linux' | ||
| ``` | ||
|
|
||
| ## Remarks |
There was a problem hiding this comment.
Lets move the remarks section above the examples section, and let's add a remark about unknown options.
| `-t, --resourceType <resourceType>` | ||
| : The resource type for which the extension is created. Allowed values are `user`, `group`, `device`, `organization`. | ||
|
|
||
| `--property1 [property1]` |
There was a problem hiding this comment.
Lets remove property 1 and 2. Instead we explain in the remarks about using unknown options.
|
|
||
| # graph openextension add | ||
|
|
||
| Creates a new open extension |
There was a problem hiding this comment.
Suggested change
| Creates a new open extension | |
| Adds an open extension to a resource |
Let's keep this description the same as the one in the command.
| try { | ||
| const requestBody: any = {}; | ||
|
|
||
| requestBody["extensionName"]= args.options.name; |
There was a problem hiding this comment.
Suggested change
| requestBody["extensionName"]= args.options.name; | |
| requestBody["extensionName"] = args.options.name; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6627