-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Client] Add a Send
or Broadcast
msg type to the debug CLI
#344
Labels
client
work needed to interface with the node (rpc, cli, etc..)
core starter task
Good for newcomers, but aimed at core team members though still open for everyone
core
Core infrastructure - protocol related
Milestone
Comments
19 tasks
16 tasks
dylanlott
added a commit
that referenced
this issue
Mar 20, 2023
…LI commands (#561) ## Description Adds a `MessageRoutingType` field for distinguishing debug message [routing types](https://en.wikipedia.org/wiki/Routing) in the debug CLI. ## Issue Fixes #344 ## Type of change Please mark the relevant option(s): - [ ] New feature, functionality or library - [ ] Bug fix - [x] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other <!-- add details here if it a different type of change --> ## List of changes - Adds a RoutingType field to the DebugMessage - Distinguishes the routing types of each message in the Debug CLI ## Testing - [x] `make develop_test` - [x] [LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md) w/ all of the steps outlined in the `README` ## Required Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have tested my changes using the available tooling - [x] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s)
dylanlott
added a commit
that referenced
this issue
Mar 24, 2023
…LI commands (#561) ## Description Adds a `MessageRoutingType` field for distinguishing debug message [routing types](https://en.wikipedia.org/wiki/Routing) in the debug CLI. ## Issue Fixes #344 ## Type of change Please mark the relevant option(s): - [ ] New feature, functionality or library - [ ] Bug fix - [x] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other <!-- add details here if it a different type of change --> ## List of changes - Adds a RoutingType field to the DebugMessage - Distinguishes the routing types of each message in the Debug CLI ## Testing - [x] `make develop_test` - [x] [LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md) w/ all of the steps outlined in the `README` ## Required Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have tested my changes using the available tooling - [x] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
work needed to interface with the node (rpc, cli, etc..)
core starter task
Good for newcomers, but aimed at core team members though still open for everyone
core
Core infrastructure - protocol related
Objective
Update the debug CLI to make it clear which debug commands are broadcasts and which are sends.
Origin Document
There was a "fly by" change made in #285 where we updated the strings in
app/client/cli/debug.go
to the available debug commands by addingbroadcast
andsend
to the end like so:#285 (comment)
The best approach to doing something like this is to update
To:
Goals
Deliverable
SEND
andBROADCAST
enum type for the debug cmdlineNon-goals / Non-deliverables
General issue deliverables
Testing Methodology
make test_all
LocalNet
is still functioning correctly by following the instructions at docs/development/README.mdCreator: @Olshansk
The text was updated successfully, but these errors were encountered: