Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] chore: add destrictive warning to docker_w*pe target #464

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Jan 25, 2023

Description

The docker_wipe make target is quite a destructive action as it destroys all containers, images, and volumes in docker. This includes things unrelated to the pocket and requires the user to re-download any docker images they may require, which can be very time consuming. Additionally, there is the potential to lose data in the destruction of the volumes. I think it's especially important that we provide a sufficient warning as we're including its usage in developer documentation.

Issue

No open issue.

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other: chore: improve developer experience

List of changes

  • Add appropriately scary warning to the docker_wipe target via a new phony dependency

Testing

  • make develop_test
  • LocalNet w/ all of the steps outlined in the README

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@bryanchriswhite bryanchriswhite added the tooling tooling to support development, testing et al label Jan 25, 2023
@bryanchriswhite bryanchriswhite self-assigned this Jan 25, 2023
@bryanchriswhite bryanchriswhite changed the title chore: add destrictive warning to docker_wipe target chore: add destrictive warning to docker_w*pe target Jan 25, 2023
@bryanchriswhite bryanchriswhite marked this pull request as ready for review January 25, 2023 18:48
@bryanchriswhite bryanchriswhite changed the title chore: add destrictive warning to docker_w*pe target [Tooling] chore: add destrictive warning to docker_w*pe target Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling tooling to support development, testing et al
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants