Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Fix SLIP Master Key and Child Key diagrams to be in the correct order #573

Merged
merged 1 commit into from
Mar 9, 2023
Merged

[Documentation] Fix SLIP Master Key and Child Key diagrams to be in the correct order #573

merged 1 commit into from
Mar 9, 2023

Conversation

h5law
Copy link
Contributor

@h5law h5law commented Mar 9, 2023

Description

The Master key generation diagram and the Child key generation diagrams are in the wrong order in the SLIP documentation. This PR puts them the correct way around

Issue

Fixes N/A

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Reorder master key and child key generation diagrams

Testing

  • make develop_test
  • LocalNet w/ all of the steps outlined in the README

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@h5law h5law requested a review from Olshansk March 9, 2023 17:28
@Olshansk Olshansk added documentation Improvements or additions to documentation code health Nice to have code improvement labels Mar 9, 2023
@h5law h5law merged commit 358f684 into main Mar 9, 2023
@h5law h5law deleted the slip-doc-fix branch March 9, 2023 20:46
bryanchriswhite added a commit that referenced this pull request Mar 16, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into chore/p2p-interfaces
dc3600c 
* pokt/main:
  [P2P] test: URL conversion with mockdns (#586)
  Create devlog4.md
  Update devlog3.md to remove demo
  Create devlog3.md
  [CLI] add private keys embed to debug cli build (#578)
  [Documentation] Fix SLIP Master Key and Child Key diagrams to be in the correct order (#573)
  add get secrets perms to cluster-manager-account service account (#572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olshansk Olshansk Olshansk approved these changes

Assignees

@h5law h5law

Labels
code health Nice to have code improvement documentation Improvements or additions to documentation
Projects
V1 Dashboard
Status: Done
Milestone
M*: Pocket QoL (Quality of Life)
Development

Successfully merging this pull request may close these issues.
2 participants
@h5law @Olshansk