[Consensus] Log warnings if server module is not enabled #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changelog validation failed with the following output:
Latest version in consensus/doc/CHANGELOG.md is incorrect.
Latest: [0.0.0.44], Previous: [0.0.0.46]
Changelog verification failed. See error messages for more detail.
Please update the relevant CHANGELOG.md files and ensure they follow the correct format.
gokutheengineer
changed the title
github-actions
bot
dismissed
their stale review
The check succeeded, dismissing the review comment.
Olshansk
approved these changes
Apr 14, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Apr 17, 2023
…p-modules * pokt/main: [Consensus] Log warnings if server module is not enabled (#679)
bryanchriswhite
added a commit
that referenced
this pull request
Apr 17, 2023
* refactor/consolidate-p2p-modules: chore: update changelog switch to new dns introduced with helm charts [Consensus] Log warnings if server module is not enabled (#679) chore: update changelog add generated helm docs chore: update validator chart P2P hostname config chore: remove `use_libp2p` from validator chart [Peristence] Fix `TxIndexer` to index sender and recipient transactions with height and index suffixes (#677) Update e2e/docs/CHANGELOG.md (#681) Update devlog5.md (#672) [Infra] validator helm chart for LocalNet (#658) Update issue.md
bryanchriswhite
added a commit
that referenced
this pull request
Apr 17, 2023
* refactor/consolidate-p2p-modules: chore: update changelog switch to new dns introduced with helm charts [Consensus] Log warnings if server module is not enabled (#679) chore: update changelog add generated helm docs chore: update validator chart P2P hostname config chore: remove `use_libp2p` from validator chart [Peristence] Fix `TxIndexer` to index sender and recipient transactions with height and index suffixes (#677) Update e2e/docs/CHANGELOG.md (#681) Update devlog5.md (#672) [Infra] validator helm chart for LocalNet (#658) Update issue.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log a warning if the server module is not enabled rather than an error.
Issue
Type of change
Please mark the relevant option(s):
List of changes
handleStateSyncMessage()to log warningsTesting
make develop_test; if any code changes were madeRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)