Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailer function #344

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Add trailer function #344

wants to merge 20 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2014

Funcion para ver trailers antes de ver la pelicula
preview:

1
2
3

@dimartiro
Copy link

genial 👍 no puedo esperar para que se haga el merge y verlo funcionando

@ghost
Copy link
Author

ghost commented Mar 10, 2014

Ya te lo podes descargar y usarlo desde github
Igual encontré un bug bastante grande, en que a veces no es el trailer de la pelicula que seleccionas pero ya encontre una forma de fixearlo y estoy en eso

@ghost
Copy link
Author

ghost commented Mar 10, 2014

Ahora uso otro metodo con el API the youtube y muestra bien todos los trailers de todas las peliculas.

@ghost
Copy link
Author

ghost commented Mar 10, 2014

Para evitar errores incluyo el año de la película en la búsqueda del trailer

@dimartiro
Copy link

Tengo la ultima version de master y todavía no veo la feature 😢

@ghost
Copy link
Author

ghost commented Mar 10, 2014

Es que tienen que aceptarla ellos para que salga en su repo.
Mientras tanto podes descargarla de aca: https://github.com/brai4you/popcorn-app
e ir a "C:\Users[user name]\AppData\Roaming\Popcorn Time\app" y remplazar con lo que tenes en el .zip para activar la feature

@dimartiro
Copy link

Impecable lo bajo desde tu fork entonces y lo miro (no se xq no se me ocurrió antes)... estoy en mac las rutas son distintas pero igual ubico! Gracias por la feature!

@gnuns
Copy link
Contributor

gnuns commented Mar 10, 2014

👍

@maracaipe
Copy link

I think change the cursor style to cursor: pointer to improve the UX in the "X" button is a great idea! What do you think?

@ghost
Copy link
Author

ghost commented Mar 10, 2014

yep, i added

@nfmelendez
Copy link

Please add this feature! or if you need more help, i can help you to improve the implementation

@EvandroZanatta
Copy link
Contributor

👍 :

@EvandroZanatta
Copy link
Contributor

inserting the translation into Portuguese
@GonzaGonza
Copy link
Contributor

We should talk about this on #219
I think that link to trailer will be nice, but we should discuess where we should put it.
If you see the linked issue you will see that there are some changes in the UI.
You did a really nice work! I will let this PR open (we cant automatically merge this PR) but the UX will be different, maybe we can grab from here the "play trailer"

Thanks!

@ghost
Copy link
Author

ghost commented Mar 13, 2014

I understand, when the new design is ready I will adapt the code
thx for read

@isra17 isra17 mentioned this pull request Mar 14, 2014
@davidgumberg
Copy link

Hey! Thanks for the contribution! Unfortunately this project is no longer being maintained, but it is being forkd by the very reputable folks at YiFy, so please resubmit your pull request to: https://github.com/Yify/popcorn-app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants