Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies in positron-proxy extension #6075

Open
5 tasks done
petetronic opened this issue Jan 22, 2025 · 2 comments
Open
5 tasks done

Update dependencies in positron-proxy extension #6075

petetronic opened this issue Jan 22, 2025 · 2 comments
Assignees
Labels
area: builds Issues related to Builds category. area: proxy Issues related to Positron Proxy category. security

Comments

@petetronic
Copy link
Collaborator

petetronic commented Jan 22, 2025

Required updates to at least the following versions:

@petetronic petetronic added area: builds Issues related to Builds category. security area: proxy Issues related to Positron Proxy category. labels Jan 22, 2025
@juliasilge juliasilge added this to the 2025.03 Pre-Release milestone Jan 22, 2025
@timtmok timtmok self-assigned this Feb 11, 2025
@timtmok
Copy link
Contributor

timtmok commented Feb 25, 2025

Updating to import { legacyCreateProxyMiddleware as createProxyMiddleware, responseInterceptor } from 'http-proxy-middleware'; allows using [email protected] without any code changes.

The change we need to adopt is how the proxy options are passed when creating it. It's purely a format change. I've tested it with the new option format and it only seems to work when using the legacy adapter. Otherwise, the proxy doesn't seem to process the requests properly. They come in and are forwarded but it's missing something for the content to load.

So I'm going forward with testing the changes while using the legacy adapter. We have time to figure out what's wrong with the options until the legacy adapter is removed in the future.

@timtmok
Copy link
Contributor

timtmok commented Mar 11, 2025

The packages have been updated. There are no changes to note for a user but this does change the dependencies used for the Viewer and Help views and launching apps. The automated tests would provide coverage for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: builds Issues related to Builds category. area: proxy Issues related to Positron Proxy category. security
Projects
None yet
Development

No branches or pull requests

3 participants