-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update http-proxy-middleware
#6728
Conversation
Update setting options on http-proxy-middleware Use legacy adapter for http-proxy-middleware
E2E Tests 🚀 |
Tests to run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Help, plots and Python apps are working for me on Mac in dev builds of Positron Server Web and Positron Desktop.
I couldn't get the FastAPI Python app to work via the App Launcher button, but I'm having the same problem on 2025.03.0 build 116, so seems unrelated. If you can reproduce also, I'll open a separate issue for that! For me, a proxy for the app would start up successfully, but the app wouldn't get launched in the Terminal.
Adding web to the test run |
Are we separately going to update express? |
Oh yes, I meant to update it here. |
This new change bumps the minimum version. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI is green 👍
Address #6075
Getting the latest
http-proxy-middleware
updates it and several other packages. The major version change does require updating how the proxy is constructed since the signature changed.The legacy constructor is used but with the new options format. Using the new constructor doesn't seem to work but we need these updates.
This was an earlier test run with the new constructor and using the legacy adapter: https://github.com/posit-dev/positron/actions?query=branch%3Afeature%2Fupdate-positron-proxy++
Run 208 uses the legacy adapter and passes. Run 217 uses the new constructor and fails all the viewer and help pane tests.
@:apps @:viewer @:help @:web
Release Notes
Updates
http-proxy-middleware
and other packages.New Features
Bug Fixes
QA Notes
This will affect the Viewer and Help panes when running HTML plots, apps, and help documentation.