Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly render icons for connections that provide custom icons #6187

Closed
dfalbel opened this issue Jan 31, 2025 · 2 comments
Closed

Correctly render icons for connections that provide custom icons #6187

dfalbel opened this issue Jan 31, 2025 · 2 comments
Assignees
@dfalbel
Labels
area: connections Issues related to Connections category. enhancement New feature or request lang: r
Milestone
2025.03.0 Pre-Rel...

Comments

@dfalbel
Copy link
Contributor

dfalbel commented Jan 31, 2025

In the new connections pane (currently behind a feature flag) , we don't correctly support custom icons following the RStudio connections contract.
@dfalbel dfalbel added area: connections Issues related to Connections category. enhancement New feature or request lang: r labels Jan 31, 2025
@dfalbel dfalbel added this to the 2025.03 Pre-Release milestone Jan 31, 2025
@dfalbel dfalbel mentioned this issue Feb 11, 2025
Merged
dfalbel added a commit that referenced this issue Feb 11, 2025
@dfalbel
Connections: Support for custom icons (#6282)
2db004b 
Addresses #6187

Add support for custom icons in the new connections pane.
The [connections
contract](https://rstudio.github.io/rstudio-extensions/connections-contract.html#examples)
allows connections to provide a custom icon, which should be a full path
to a squared png file.
@dfalbel dfalbel self-assigned this Feb 11, 2025
@jonvanausdeln
Copy link
Contributor

When trying the following on Windows 11, the icon doesn't render

install.packages("FactoMineR")
remotes::install_github("ColinFay/fryingpane")

library(fryingpane)
cook("FactoMineR")

I see

Image

In the console I see

Image

But I do see the file on disk

C:\Users\JonVanausdeln\AppData\Local\R\win-library\4.4\fryingpane\img> ls

    Directory: C:\Users\JonVanausdeln\AppData\Local\R\win-library\4.4\fryingpane\img

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---           2/14/2025 10:37 AM           4833 fryingpan.png
-a---           2/14/2025 10:37 AM           5607 package.png

@dfalbel dfalbel mentioned this issue Feb 14, 2025
Merged
@jonvanausdeln
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2025.02.0-171
OS Version(s) : Windows 11

Test scenario(s)

Custom icon now shows on all platforms!

Link(s) to TestRail test cases run or created:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dfalbel dfalbel

Labels
area: connections Issues related to Connections category. enhancement New feature or request lang: r
Projects
None yet
Milestone
2025.03.0 Pre-Release
Development

No branches or pull requests
2 participants
@dfalbel @jonvanausdeln