Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply an automatic dark theme to plots in dark themes #6256

Merged
merged 11 commits into from
Feb 10, 2025

Conversation

jmcphers
Copy link
Collaborator

@jmcphers jmcphers commented Feb 10, 2025

Quick little airplane feature to make plots in Positron's Plots pane (and editors) automatically turn dark in dark themes. It's intended for exploratory data analysis, wherein you're not preparing plots for publication but just using them as a visualization tool.

Screen.Recording.2025-02-10.at.8.32.50.AM.mov

Because I expect that this feature will be somewhat polarizing, it is controlled by a explicit configuration setting rather than an implicitly saved preference. You can turn it off at user level, workspace level, etc. in Settings.

image

Addresses #6255.

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

It is possible to change the dark filter mode right on the Plots pane by clicking the color mode drop down. Note however that this only changes it temporarily! If you want the change to stick (across reloads, etc.) you need to do that in Settings. Changing the value in Settings should cause the UI to react appropriately.

I briefly considered having the dropdown update the setting for you but there's really too much guessing there (did you mean to turn it off for all projects? just this one? etc.)

Test tags: @:plots

Copy link

github-actions bot commented Feb 10, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:plots

readme  valid tags

@jmcphers jmcphers requested a review from timtmok February 10, 2025 16:55
@jmcphers jmcphers changed the title Feature/dark mode plots Apply an automatic dark theme to plots in dark themes Feb 10, 2025
Copy link
Contributor

@timtmok timtmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

We will soon need a different way, like a menu or scrolling, to handle the number of buttons.

@jmcphers
Copy link
Collaborator Author

We will soon need a different way, like a menu or scrolling, to handle the number of buttons.

You're right. I think a few of these can be grouped; almost refactored this so that filmstrip mode and color filter were in a new settings 'view options' group.

@jmcphers jmcphers merged commit f964341 into main Feb 10, 2025
11 checks passed
@jmcphers jmcphers deleted the feature/dark-mode-plots branch February 10, 2025 20:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants