block interpreters from Positron dropdown #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
isabelizimm
commented
Feb 27, 2025
| @@ -116,7 +118,14 @@ export class PythonRuntimeManager implements IPythonRuntimeManager { | |||
| */ | |||
| public registerLanguageRuntime(runtime: positron.LanguageRuntimeMetadata): void { | |||
| const extraData = runtime.extraRuntimeData as PythonRuntimeExtraData; | |||
| const pythonVersion: PythonVersion = toSemverLikeVersion(parseVersion(runtime.languageVersion)); | |||
There was a problem hiding this comment.
this seems to be the best way to get from a version string to the PythonVersion type. toSemverLikeVersion is only used in legacy code upstream, so it has been deprecated.
I'm happy to put together a custom function for us if we don't want the deprecated function though.
testlabauto
approved these changes
Feb 27, 2025
seeM
approved these changes
Feb 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should block <3.8 interpreters from being registered when found. It seems to fix everything for me locally, I think this is the only place where old interpreters could sneak by.
Release Notes
New Features
Bug Fixes
QA Notes
Python: Select Interpreter, should not appear in dropdown