Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extension support - clean version #204

Closed
wants to merge 3 commits into from
Closed

Fixed extension support - clean version #204

wants to merge 3 commits into from

Conversation

swernerx
Copy link
Contributor

@swernerx swernerx commented May 5, 2016

Clean version of previous PR

@MoOx
Copy link
Contributor

MoOx commented May 5, 2016

What is this fixing? Is this fixing #197 ?
Could you add some tests? Tests help to understand the issue you are fixing :)

@swernerx
Copy link
Contributor Author

swernerx commented May 5, 2016

I am actually not sure whether it fixes #197... it theory it could.

Generally it would be smart for postcss-import to pass the given selection of extensions to the resolver - this was not done previously.

The second commit is more about mixed environments e.g. where a "classical" css file imports a sugarss one which imports an .scss file.

I have a project combining these things:
https://github.com/sebastian-software/modern-spa-boilerplate/tree/master/src

I have had some hard time getting understanding the test suite structure... for know I just check whether I do not break existing functionality.

@MoOx
Copy link
Contributor

MoOx commented May 7, 2016

I can't add feature (that you consider as fixes) without any tests (and I don't currently have time to handle those).

@swernerx
Copy link
Contributor Author

swernerx commented May 7, 2016

Okay, I understand. I am also not sure about the time required. What exactly do you expect from the test? Anything specific to cover.... ? Otherwise I will just try to have the basics done.

@MoOx
Copy link
Contributor

MoOx commented May 9, 2016

Nothing specific, just basic tests please.

@linxixuan
Copy link

why not merged yet? I need this !

@izolate
Copy link

izolate commented Oct 12, 2016

@swernerx Please can you add some tests so we can get this PR merged in?

@RyanZim RyanZim mentioned this pull request Nov 11, 2016
@RyanZim
Copy link
Collaborator

RyanZim commented Dec 3, 2016

Superseded by #245. That PR went a slightly different direction, but some ideas were loosely based on this PR, so thanks @swernerx!

@RyanZim RyanZim closed this Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants