-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed extension support - clean version #204
Fixed extension support - clean version #204
Conversation
What is this fixing? Is this fixing #197 ? |
I am actually not sure whether it fixes #197... it theory it could. Generally it would be smart for postcss-import to pass the given selection of extensions to the resolver - this was not done previously. The second commit is more about mixed environments e.g. where a "classical" css file imports a sugarss one which imports an .scss file. I have a project combining these things: I have had some hard time getting understanding the test suite structure... for know I just check whether I do not break existing functionality. |
I can't add feature (that you consider as fixes) without any tests (and I don't currently have time to handle those). |
Okay, I understand. I am also not sure about the time required. What exactly do you expect from the test? Anything specific to cover.... ? Otherwise I will just try to have the basics done. |
Nothing specific, just basic tests please. |
why not merged yet? I need this ! |
@swernerx Please can you add some tests so we can get this PR merged in? |
Clean version of previous PR