support all AE versions

initialize gmst strings once
powerof3 · Oct 2, 2022 · fb84bfd · fb84bfd
1 parent 51228f7
commit fb84bfd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/src/Manager.cpp b/src/Manager.cpp
@@ -2,7 +2,15 @@
 
 namespace UI
 {
-	namespace CrossHair
+	namespace gmst
+	{
+		const char* get_string(const char* a_setting)
+		{
+			return RE::GameSettingCollection::GetSingleton()->GetSetting(a_setting)->GetString();
+		}
+	}
+
+    namespace CrossHair
 	{
 		enum : std::uint32_t
 		{
@@ -21,10 +29,8 @@ namespace UI
 
 			static std::string get_owned_tag()
 			{
-				std::string tag{ " (" };
-				tag.append(RE::GameSettingCollection::GetSingleton()->GetSetting("sOwned")->GetString());
-				tag.append(")");
-				return tag;
+				static std::string tag = std::string(" (").append(gmst::get_string("sOwned")).append(")");
+			    return tag;
 			}
 		};
 
@@ -116,8 +122,7 @@ namespace UI
 		{
 			static std::string get_To_tag()
 			{
-				auto tag = std::string(RE::GameSettingCollection::GetSingleton()->GetSetting("sTo")->GetString());
-				tag.append(" ");
+				static std::string tag = std::string(gmst::get_string("sTo")).append(" ");
 				return tag;
 			}
 		};

diff --git a/src/main.cpp b/src/main.cpp
@@ -17,7 +17,7 @@ extern "C" DLLEXPORT constinit auto SKSEPlugin_Version = []() {
 	v.PluginName("SimpleActivateSKSE");
 	v.AuthorName("powerofthree");
 	v.UsesAddressLibrary();
-	v.UsesUpdatedStructs();
+	v.UsesNoStructs();
 	v.CompatibleVersions({ SKSE::RUNTIME_LATEST });
 
 	return v;